Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

fix string type cast ambiguity #449

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Aug 17, 2020


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio requested review from fedekunze and noot as code owners August 17, 2020 11:59
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #449 into sdk-0.39 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           sdk-0.39     #449   +/-   ##
=========================================
  Coverage     70.18%   70.18%           
=========================================
  Files            38       38           
  Lines          2485     2485           
=========================================
  Hits           1744     1744           
  Misses          610      610           
  Partials        131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb6337...4200c4f. Read the comment docs.

@fedekunze fedekunze merged commit 4be4ebc into cosmos:sdk-0.39 Aug 17, 2020
@alessio alessio deleted the alessio/sdk-0.39 branch August 17, 2020 12:45
fedekunze added a commit that referenced this pull request Aug 23, 2020
* bump sdk version to v0.39.0 candidate

* updates

* update evm

* bump commit

* more changes

* build

* genesis

* fix tests

* fix tests

* bump commit

* bump commit

* bump commit

* add keygen func

* bump version to 0.39.0-rc0

* update AnteHandler

* fix TxDecoder

* lint

* fix test

* update statedb

* changelog

* fixes

* remove extra files

* update make test-import

* rename test

* bump SDK version to final release

* update to 0.39.1-rc1

* fix evm tests

* update RPC

* minor fixes

* update to rc2

* bump to v0.39.1

* fix personal API

* fix string type cast ambiguity (#449)

* init

* fix estimate gas test

* minor genesis change

* remove comments from unstable commit (stargate release)

Co-authored-by: Alessio Treglia <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants