This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
bump SDK to v0.39.1 #386
Merged
bump SDK to v0.39.1 #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #386 +/- ##
===============================================
- Coverage 70.83% 69.92% -0.91%
===============================================
Files 38 38
Lines 2465 2487 +22
===============================================
- Hits 1746 1739 -7
- Misses 589 617 +28
- Partials 130 131 +1
Continue to review full report at Codecov.
|
fedekunze
changed the title
fedekunze
changed the title
|
I'm getting this error on the RPC tests. Seems that the ethermint pubkey is not registered on the amino codec |
|
All the tests have been fixed now 🎉 |
app/ante/ante_test.go
Outdated
| err := suite.app.BankKeeper.SetBalances(suite.ctx, acc1.GetAddress(), newTestCoins()) | ||
| suite.Require().NoError(err) | ||
| // err := suite.app.BankKeeper.SetBalances(suite.ctx, acc1.GetAddress(), newTestCoins()) | ||
| // suite.Require().NoError(err) |
There was a problem hiding this comment.
Is there a reason why all these commented lines are still in here? These should get removed.
There was a problem hiding this comment.
I left all the commented lines for ease of upgrading later on. I can remove it and reference the commit on an issue if that's better
There was a problem hiding this comment.
No thats fine. I was just curious
There was a problem hiding this comment.
I think you are right and I should clean up the comments, it doesn't look clean
araskachoi
approved these changes
Aug 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IMPORTANT: only tested ACK reviews please (i.e review code + deploy contracts/test functionality)
TODO:
make test-importFor contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)