Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement x/params get all subspaces/keys #9884

Merged
merged 11 commits into from
Aug 10, 2021

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 9, 2021

Description

closes: #9873


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@orijbot
Copy link

orijbot commented Aug 9, 2021

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #9884 (1231ded) into master (59f63a2) will increase coverage by 0.09%.
The diff coverage is 95.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9884      +/-   ##
==========================================
+ Coverage   63.50%   63.59%   +0.09%     
==========================================
  Files         568      568              
  Lines       53350    53490     +140     
==========================================
+ Hits        33879    34019     +140     
+ Misses      17549    17547       -2     
- Partials     1922     1924       +2     
Impacted Files Coverage Δ
client/context.go 58.28% <ø> (+2.06%) ⬆️
x/params/keeper/grpc_query.go 73.68% <68.18%> (-7.57%) ⬇️
x/auth/client/testutil/suite.go 96.83% <100.00%> (+0.27%) ⬆️
x/params/keeper/keeper.go 82.35% <100.00%> (+5.42%) ⬆️
x/params/types/subspace.go 81.81% <100.00%> (+1.22%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@alexanderbez alexanderbez changed the title feature: implement x/params get all subspaces/keys feat: implement x/params get all subspaces/keys Aug 9, 2021
@alexanderbez alexanderbez marked this pull request as ready for review August 9, 2021 15:27
@alexanderbez alexanderbez requested a review from aaronc as a code owner August 9, 2021 15:27
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderbez alexanderbez merged commit 055e7e8 into master Aug 10, 2021
@alexanderbez alexanderbez deleted the bez/9873-params-queries branch August 10, 2021 12:45
@amaury1093 amaury1093 mentioned this pull request May 20, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query params module for list of subspaces and keys
4 participants