Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate and improve paramater documenting process #1054

Closed
1 of 7 tasks
dcwalk opened this issue Nov 5, 2021 · 5 comments
Closed
1 of 7 tasks

Automate and improve paramater documenting process #1054

dcwalk opened this issue Nov 5, 2021 · 5 comments
Assignees
Labels
scope: docs Improvements or additions to documentation

Comments

@dcwalk
Copy link
Contributor

dcwalk commented Nov 5, 2021

Summary

As part of the gov->gaia merge we now have a script that queries the parameters, and a way to display those parameters on hub.cosmos.network (https://hub.cosmos.network/main/governance/params-change/param_index.html).
This is an enhancement that builds on #68 , PR to enable that post-merge is here: #1051. However there are some improvements and automation we can/should do to make the process less manual / prone to falling out of date

Problem Definition

However the process is manual / prone to falling out of date and so there are some improvements and automation we can/should do!

Proposal

We should:

  • update the script to try a few nodes vs. one to be a little more future proof
  • update the script to query for the subspace keys instead of hardcoding them (post- feat: implement x/params get all subspaces/keys cosmos-sdk#9884)
  • integrate running the script + updating params into docs build process? (in makefile docs-build? in gh actions?)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dcwalk dcwalk added the scope: docs Improvements or additions to documentation label Nov 5, 2021
@dcwalk
Copy link
Contributor Author

dcwalk commented Nov 10, 2021

Sam mentioned we using peers from chain registry: https://github.com/cosmos/chain-registry/blob/master/cosmoshub/chain.json

It looks like the new subspaces query currently unreleased in cosmos-sdk (#9884): https://github.com/cosmos/cosmos-sdk/blob/master/CHANGELOG.md so we are blocked on that part until a release + in gaia

@nooomski
Copy link
Contributor

nooomski commented Jan 4, 2022

Bot accidentally closed this. Opening again.

@nooomski nooomski reopened this Jan 4, 2022
@stale stale bot removed the stale label Jan 4, 2022
@okwme
Copy link
Contributor

okwme commented Jan 31, 2022

hey @dcwalk and @uditvira any updates on this issue? Should we icebox it or add #nice-to-have as a label or is it proressing?

@dcwalk
Copy link
Contributor Author

dcwalk commented Feb 1, 2022

I think we were waiting on an unreleased feature of cosmos-sdk: #9884 Provide a new gRPC query handler, /cosmos/params/v1beta1/subspaces, that allows the ability to query for all registered subspaces and their respective keys.

Quickly checking I still see that as unreleased.

This is a good candidate for #nice-to-have as the first version is committed to the docs :)

@okwme
Copy link
Contributor

okwme commented Apr 25, 2022

closed since cosmos/cosmos-sdk#9884 was merged

@okwme okwme closed this as completed Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants