lcd test cleanup

[ebuchman]

#624

[codecov]

Codecov Report

Merging #625 into fabo/383-rest-server will decrease coverage by 2.74%.
The diff coverage is 56.79%.

@@                   Coverage Diff                    @@
##           fabo/383-rest-server     #625      +/-   ##
========================================================
- Coverage                 65.87%   63.13%   -2.75%     
========================================================
  Files                         8       38      +30     
  Lines                       378     2094    +1716     
========================================================
+ Hits                        249     1322    +1073     
- Misses                      102      666     +564     
- Partials                     27      106      +79

[ebuchman]

@adrianbrink @rigelrozanski @faboweb see how I set up the Tendermint/LCD in process here.

Could still use some love :)

[faboweb]

you set chainID in line 50 but use ctx.ChainID() here again.

[faboweb]

Amazing work. Thanks a lot. Sorry to see it was still that much todo.

[mappum]

In the sendtx endpoint, is there a reason the address comes from the querystring and not the body?

cosmos-sdk/x/bank/rest/sendtx.go

Lines 20 to 36 in 6485213

	type sendBody struct {
	// fees is not used currently
	// Fees sdk.Coin `json="fees"`
	Amount sdk.Coins `json:"amount"`
	LocalAccountName string `json:"name"`
	Password string `json:"password"`
	ChainID string `json:"chain_id"`
	Sequence int64 `json:"sequence"`
	}
	// SendRequestHandler - http request handler to send coins to a address
	func SendRequestHandler(cdc *wire.Codec, kb keys.Keybase) func(http.ResponseWriter, *http.Request) {
	c := commands.Commander{cdc}
	return func(w http.ResponseWriter, r *http.Request) {
	// collect data
	vars := mux.Vars(r)
	address := vars["address"]

[mappum]

NVM, it's in the URL path, that makes sense 👍