You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@faboweb made some heroic efforts to get the LCD in place: #544
That said, the client/lcd/lcd_test.go is using the unreviewed/unfinished integration tests from #596. These are integration tests that are written in Go to call the basecoind and basecli binaries - we shouldn't be using them to test the base functionality of the LCD.
So, some work needs to be done to spin up the Basecoind and LCD nodes in-process, without using the binaries at all. This requires some refactoring across the LCD to remove side-effects and dependence on global variables like viper.
I've taken a first stab at this in #625 . It doesn't compile yet and needs some love. We need to do things like setup the Keybase once up front and pass it through rather than relying on the side-effecting/global GetKeybase function called everywhere.
Would greatly appreciate some help here. It's a priority to get this code into high quality maintainable shape and it's not Fabo's responsibility to do so.
To be clear we should remove the tests package completely from develop in this excercise as there's no need for it at all for the LCD unit tests. We will review and merge that package independently from PR #596
The text was updated successfully, but these errors were encountered:
@faboweb made some heroic efforts to get the LCD in place: #544
That said, the
client/lcd/lcd_test.go
is using the unreviewed/unfinished integration tests from #596. These are integration tests that are written in Go to call the basecoind and basecli binaries - we shouldn't be using them to test the base functionality of the LCD.So, some work needs to be done to spin up the Basecoind and LCD nodes in-process, without using the binaries at all. This requires some refactoring across the LCD to remove side-effects and dependence on global variables like viper.
I've taken a first stab at this in #625 . It doesn't compile yet and needs some love. We need to do things like setup the
Keybase
once up front and pass it through rather than relying on the side-effecting/globalGetKeybase
function called everywhere.Would greatly appreciate some help here. It's a priority to get this code into high quality maintainable shape and it's not Fabo's responsibility to do so.
To be clear we should remove the
tests
package completely from develop in this excercise as there's no need for it at all for the LCD unit tests. We will review and merge that package independently from PR #596The text was updated successfully, but these errors were encountered: