-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Added querier for auth module #3767
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3767 +/- ##
===========================================
- Coverage 61.41% 61.39% -0.02%
===========================================
Files 189 190 +1
Lines 14098 14120 +22
===========================================
+ Hits 8658 8669 +11
- Misses 4884 4894 +10
- Partials 556 557 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks @ironman0x7b2. I left a few minor comments 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM -- it just needs a pending log entry.
|
@jackzampolin nothing to do with this PR. It's an already existing regression: #3739 |
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: