Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Added querier for auth module #3767

Merged
merged 7 commits into from
Mar 1, 2019
Merged

R4R: Added querier for auth module #3767

merged 7 commits into from
Mar 1, 2019

Conversation

ironman0x7b2
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #3767 into develop will decrease coverage by 0.01%.
The diff coverage is 59.09%.

@@             Coverage Diff             @@
##           develop    #3767      +/-   ##
===========================================
- Coverage    61.41%   61.39%   -0.02%     
===========================================
  Files          189      190       +1     
  Lines        14098    14120      +22     
===========================================
+ Hits          8658     8669      +11     
- Misses        4884     4894      +10     
- Partials       556      557       +1

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @ironman0x7b2. I left a few minor comments 👍

client/context/query.go Show resolved Hide resolved
client/context/query.go Outdated Show resolved Hide resolved
x/auth/querier.go Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM -- it just needs a pending log entry.

@jackzampolin
Copy link
Member

--- FAIL: TestBonding (5.21s)
	Error Trace:	lcd_test.go:557
	Error:      	Not equal: 
	            	expected: 30000000.000000000000000000
	            	actual  : 29700000.000000000000000000
	            	
	            	Diff:
	            	--- Expected
	            	+++ Actual
	            	@@ -1,2 +1,2 @@
	            	-(types.Dec) 30000000.000000000000000000
	            	+(types.Dec) 29700000.000000000000000000
	            	 
	Test:       	TestBonding

@alexanderbez
Copy link
Contributor

@jackzampolin nothing to do with this PR. It's an already existing regression: #3739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants