Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Query-proposals CLI command #1845

Merged
merged 1 commit into from
Jul 30, 2018
Merged

R4R: Query-proposals CLI command #1845

merged 1 commit into from
Jul 30, 2018

Conversation

sunnya97
Copy link
Member

@sunnya97 sunnya97 commented Jul 27, 2018

  • Linked to github-issue with discussion and accepted design
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 27, 2018

Codecov Report

Merging #1845 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1845   +/-   ##
========================================
  Coverage    63.83%   63.83%           
========================================
  Files          118      118           
  Lines         7024     7024           
========================================
  Hits          4484     4484           
  Misses        2285     2285           
  Partials       255      255

@sunnya97 sunnya97 force-pushed the sunny/query-proposals-cli branch from cd896a5 to a28169c Compare July 27, 2018 01:01
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we add a way to start at a nonzero proposal ID - or iterate backwards, e.g. "most recent 5 proposals"?

@alexanderbez
Copy link
Contributor

failed due to: unused CommitStoreLoader: KVStoreKey{0xc420c5c5e0, params} 😦

@rigelrozanski
Copy link
Contributor

@alexanderbez did you run a command to make it fail? CI is passing we should integrate in this failing test if so

@ValarDragon
Copy link
Contributor

Did that fail in Gaiad export? There may be an issue with circle CI caching or something there, since it also errored on my PR in #1862. We may want to consider disabling the GaiadExport command or investigating / better logging whats going on there.

@alexanderbez
Copy link
Contributor

@rigelrozanski no I just simply got that from the failed build output. Seems to pass now?

@alexanderbez alexanderbez force-pushed the sunny/query-proposals-cli branch from 45f98cd to 8e7a9dd Compare July 30, 2018 15:07
@alexanderbez
Copy link
Contributor

Fixed pending changelog. Was @cwgoes comment ever addressed?

@alexanderbez alexanderbez force-pushed the sunny/query-proposals-cli branch from 8e7a9dd to 667b2f4 Compare July 30, 2018 15:11
@alexanderbez alexanderbez changed the title R4R: Query-proposals Cli command R4R: Query-proposals CLI command Jul 30, 2018
@sunnya97
Copy link
Member Author

@cwgoes's request was added

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants