-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/stake: Speed up handleMsgEditValidator #1862
Conversation
This removes running the power update logic on handleMsgEditValidator, as its unnecessary. Closes #1815
// function updates all validator stores as well as tendermint update store. | ||
// It may kick out validators if new validator is entering the bonded validator | ||
// It may kick out validators if a new validator is entering the bonded validator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think it was worth the overhead of making a separate PR for these typo fixes, so I just included it here.
I don't understand why this is causing an error in TestGaiadExport
|
This is passing locally for me |
It passed on rerunning, I think it was a cache issue. https://circleci.com/gh/cosmos/cosmos-sdk/18848#queue-placeholder/containers/1 |
yeah it's the non-determinism |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
This removes running the power update logic on handleMsgEditValidator,
as its unnecessary.
Closes #1815
docs/
) - n/a??PENDING.md
that include links to the relevant issue or PR that most accurately describes the change.cmd/gaia
andexamples/
- n/aFor Admin Use: