Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/stake: Speed up handleMsgEditValidator #1862

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

ValarDragon
Copy link
Contributor

This removes running the power update logic on handleMsgEditValidator,
as its unnecessary.

Closes #1815

  • Linked to github-issue with discussion and accepted design
  • Updated all relevant documentation (docs/) - n/a??
  • Updated all relevant code comments
  • Wrote tests - n/a?
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/ - n/a

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

This removes running the power update logic on handleMsgEditValidator,
as its unnecessary.

Closes #1815
// function updates all validator stores as well as tendermint update store.
// It may kick out validators if new validator is entering the bonded validator
// It may kick out validators if a new validator is entering the bonded validator
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think it was worth the overhead of making a separate PR for these typo fixes, so I just included it here.

@ValarDragon
Copy link
Contributor Author

I don't understand why this is causing an error in TestGaiadExport

=== RUN   TestGaiadExport
D[07-28|04:45:41.035] Commit synced                                commit="CommitID{[186 108 234 48 202 251 102 117 88 206 245 9 3 193 123 244 147 82 77 162]:1}"
unused CommitStoreLoader: KVStoreKey{0xc420209650, params}
FAIL	github.com/cosmos/cosmos-sdk/cmd/gaia/app	0.132s

@ValarDragon
Copy link
Contributor Author

This is passing locally for me

@ValarDragon
Copy link
Contributor Author

It passed on rerunning, I think it was a cache issue. https://circleci.com/gh/cosmos/cosmos-sdk/18848#queue-placeholder/containers/1

@rigelrozanski
Copy link
Contributor

yeah it's the non-determinism

Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@rigelrozanski rigelrozanski merged commit c40d5de into develop Jul 30, 2018
@rigelrozanski rigelrozanski deleted the dev/speed_up_handleMsgEditValidator branch July 30, 2018 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Performance Performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants