Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simapp): do not create data dir at each run #17240

Merged
merged 4 commits into from
Aug 3, 2023
Merged

fix(simapp): do not create data dir at each run #17240

merged 4 commits into from
Aug 3, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 1, 2023 •
edited
Loading

Description

ref: #17238, #17238 (review)

  • stop creating a data dir folder at each simapp run
  • deduplicate root.go and root_v2.go (I think we should have a better name however than cmd.go)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 1, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner August 1, 2023 10:35
@julienrbrt julienrbrt changed the title fix: do not create data dir at each simapp run fix(simapp): do not create data dir at each run Aug 1, 2023
@github-prbot github-prbot requested review from a team, facundomedica and testinginprod and removed request for a team August 1, 2023 10:39
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

@julienrbrt your pull request is missing a changelog!

@julienrbrt
Copy link
Member Author

@julienrbrt your pull request is missing a changelog!

It's a regression of v0.50 so no changelog needed.

facundomedica
facundomedica approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit b61f611 Aug 3, 2023
@julienrbrt julienrbrt deleted the julien/data-dir branch August 3, 2023 12:45
mergify bot pushed a commit that referenced this pull request Aug 3, 2023
@julienrbrt @mergify
fix(simapp): do not create data dir at each run (#17240)
bf5472f 
(cherry picked from commit b61f611)

# Conflicts:
#	simapp/simd/cmd/root.go
#	simapp/simd/cmd/root_v2.go
@mergify mergify bot mentioned this pull request Aug 3, 2023
Merged
julienrbrt added a commit that referenced this pull request Aug 3, 2023
@mergify @julienrbrt
fix(simapp): do not create data dir at each run (backport #17240) (#1…
8375a67 
…7275)

Co-authored-by: Julien Robert <[email protected]>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundomedica facundomedica facundomedica approved these changes

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @facundomedica