refactor(x/upgrade): create directory when dump disk

[zakir-code]

Description

• homePath may be empty, and I couldn't find the reason for it, which causes the data directory to be created in the current directory every timesimd is used.

cosmos-sdk/x/upgrade/module.go

Line 206 in 320eea1

homePath = cast.ToString(in.AppOpts.Get(flags.FlagHome))

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• run make lint and make test
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

Best to look at the root cause and avoid API breaks.
It seems like at the injection of the upgrade module (for the client), no server options are provided.
So this isn't true:

cosmos-sdk/x/upgrade/module.go

Line 201 in 31f7247

if in.AppOpts != nil {

We should update root_v2.go to create a temporary folder like we do for root.go.
The client part has nothing to do with upgrade, so it is fine to do so.

		depinject.Configs(simapp.AppConfig,
			depinject.Supply(
				log.NewNopLogger(),
+				simtestutil.NewAppOptionsWithFlagHome(tempDir()),
			),
		),

Eventually, #16727 will solve the problem in a nicer way, where we could provide by default a temporary home and a default noop logger.

[zakir-code]

Thank you for the help. I'm going to close this PR now.