refactor(types)!: remove IntProto and DecProto
#16918
Conversation
robert-zaremba
changed the title
github-prbot
requested review from
tac0turtle and
testinginprod
and removed request for
a team
| @@ -1,9 +0,0 @@ | |||
| package types | |||
|
|
|||
| func (ip IntProto) String() string { | |||
There was a problem hiding this comment.
Can you make a PR targeting v0.50 branch that adds the deprecated flag to theses and a proto annotation?
There was a problem hiding this comment.
So, we don't want to merge it directly to v0.50?
There was a problem hiding this comment.
I suppose we could too. Have you used sourcegraph / gh search to verify no one depends on it?
There was a problem hiding this comment.
After a quick search I think the best path is to deprecate in v0.50 and removing in main.
There was a problem hiding this comment.
so, is anyone using it?
There was a problem hiding this comment.
- https://github.com/terra-money/classic-core/blob/main/x/treasury/keeper/keeper.go#L127
- https://github.com/cosmos/ibc-go/blob/main/modules/apps/transfer/keeper/keeper.go#L198-L199
Yeah but it is easy to replace. Hence the deprecating first.
There was a problem hiding this comment.
OK, will handle that once this is merged.
|
Tests are flaky, for example:
|
|
need one more review |
julienrbrt
changed the title
IntProto and DecProto
Description
Closes: #15949
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change