-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Remove DecProto #15949
Labels
Comments
Happy to handle it if others agree with the proposal. |
As it is not used, and it allows us to remove more things in |
19 tasks
Do you still want to submit a PR? (ref #16798 (comment)) |
Sure, I can remove |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Definition
DecProto
is not used anywhere, and I've seen some project using it instead ofDec
type (which correctly implements Protobuf).Proposal
To avoid confusions, we can simply remove
DecProto
.Considerations
Advantage of having
DecProto
is the ability to write in the proto files:Disadvantages: more code and confusions in Go side of having Dec and DecProto.
The text was updated successfully, but these errors were encountered: