refactor!: remove types/math aliases
#16798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.50.x
github-prbot
requested review from
JeancarloBarrios
and removed request for
a team
julienrbrt
commented
Jun 30, 2023
proto/cosmos/base/v1beta1/coin.proto
Outdated
There was a problem hiding this comment.
I'll be tagging a new api module after this PR.
EDIT: not needed yet, let's wait instead.
julienrbrt
commented
Jun 30, 2023
CHANGELOG.md
Outdated
| @@ -243,8 +243,8 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * `MsgSendExec` test helper function now takes a address.Codec | |||
| * (x/genutil) [#15567](https://github.com/cosmos/cosmos-sdk/pull/15567) `CollectGenTxsCmd` & `GenTxCmd` takes a address.Codec to be able to decode addresses | |||
| * (x/genutil) [#15999](https://github.com/cosmos/cosmos-sdk/pull/15999) Genutil now takes the `GenesisTxHanlder` interface instead of deliverTx. The interface is implemented on baseapp | |||
| * (types/math) [#16040](https://github.com/cosmos/cosmos-sdk/pull/16040) Remove unused aliases in math.go | |||
| * (x/gov) [#16106](https://github.com/cosmos/cosmos-sdk/pull/16106) Remove gRPC query methods from Keeper | |||
| * (types/math) [#16040](https://github.com/cosmos/cosmos-sdk/pull/16040) Remove aliases in `types/math.go`. | |||
There was a problem hiding this comment.
This changelog already exists, so I do not think we need another changelog for the final release however, for the alpha it may still be useful to have a changelog. We can collapse them at the final release.
julienrbrt
commented
Jun 30, 2023
| NewInt = sdkmath.NewInt | ||
| ZeroInt = sdkmath.ZeroInt | ||
| ) | ||
|
|
||
| func (ip IntProto) String() string { |
There was a problem hiding this comment.
We could remove these if this is ACK: #15949
But this is out of scope of #14405 / #14405 (comment)
There was a problem hiding this comment.
lets do this in a folllow up
tac0turtle
approved these changes
Jun 30, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
(cherry picked from commit 8c72f66) # Conflicts: # CHANGELOG.md # x/auth/migrations/v2/store.go # x/tx/signing/aminojson/internal/buf.lock
julienrbrt
added a commit
that referenced
this pull request
Jun 30, 2023
Co-authored-by: Julien Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14405
ref #16475 (comment)
protocgen.shto re-generate all tests protos (one was missing)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change