feat(auth,client/v2): add validator address codec #16768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.50.x
19 tasks
julienrbrt
changed the title
julienrbrt
commented
Jun 29, 2023
There was a problem hiding this comment.
I'll be tagging a new API version after this PR so we can use that in release/v0.50.x as well
github-prbot
requested review from
a team,
alexanderbez and
facundomedica
and removed request for
a team
|
I'll fix the tests tomorrow, but tested with simapp that it works. |
kocubinski
reviewed
Jun 30, 2023
| @@ -184,7 +184,7 @@ message QueryValidatorDelegationsResponse { | |||
| // Query/ValidatorUnbondingDelegations RPC method | |||
| message QueryValidatorUnbondingDelegationsRequest { | |||
| // validator_addr defines the validator address to query for. | |||
| string validator_addr = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; | |||
| string validator_addr = 1 [(cosmos_proto.scalar) = "cosmos.ValidatorAddressString"]; | |||
There was a problem hiding this comment.
What's the effect of this, in other words, where do we consume this changed option? Looking at generated protos only the packed message descriptors have changed.
There was a problem hiding this comment.
Here: https://github.com/cosmos/cosmos-sdk/blob/v0.50.0-alpha.0/client/v2/autocli/flag/field.go#L160 and in the builder.go file changed in this PR
kocubinski
approved these changes
Jun 30, 2023
tac0turtle
approved these changes
Jun 30, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
(cherry picked from commit 02b7607) # Conflicts: # CHANGELOG.md # client/v2/go.mod # client/v2/go.sum # go.mod # go.sum # simapp/go.mod # simapp/go.sum # tests/go.mod # tests/go.sum
julienrbrt
added a commit
that referenced
this pull request
Jun 30, 2023
…16789) Co-authored-by: Julien Robert <[email protected]>
This was referenced Jul 13, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16767, ref #13140
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change