Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmos_proto.scalar annotation should correctly represent validator and consensus address #15874

Closed
aaronc opened this issue Apr 18, 2023 · 1 comment
Closed

cosmos_proto.scalar annotation should correctly represent validator and consensus address #15874

aaronc opened this issue Apr 18, 2023 · 1 comment
Labels
T:Bug

Comments

@aaronc
Copy link
Member

aaronc commented Apr 18, 2023

Whenever we have bech32 addresses in our .proto files currently, we always write [(cosmos_proto.scalar) = "cosmos.AddressString"], but this is only correct for account addresses.

For validator addresses (ex. cosmosvaloper12345) or consensus addresses (ex cosmosvalcons12345) we should use cosmos.ValidatorAddressString and cosmos.ConsensusString respectively.

This will become more important in the future once there is more tooling built around these annotations as we already do in x/tx for signing.
@aaronc aaronc added the T:Bug label Apr 18, 2023
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Apr 18, 2023
@aaronc aaronc mentioned this issue Apr 18, 2023
Merged
19 tasks
@julienrbrt julienrbrt removed the needs-triage Issue that needs to be triaged label Jul 13, 2023
@julienrbrt
Copy link
Member

julienrbrt commented Jul 13, 2023 •
edited
Loading

I went through the whole protos files and fixed disparities in the following PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronc @julienrbrt