Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove x/gov module dependencies in x/staking #16567

Merged
merged 5 commits into from
Jun 15, 2023

Conversation

atheeshp
Copy link
Contributor

Description

Closes: #16472
ref: #13025


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp marked this pull request as ready for review June 15, 2023 07:05
@atheeshp atheeshp requested a review from a team as a code owner June 15, 2023 07:05
@atheeshp atheeshp requested a review from kocubinski June 15, 2023 07:05
@github-prbot github-prbot requested review from a team and tac0turtle and removed request for a team June 15, 2023 07:05
@faddat
Copy link
Contributor

faddat commented Jun 15, 2023

this is good :D

@atheeshp atheeshp requested a review from julienrbrt June 15, 2023 09:16
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -50,4 +50,5 @@ var (
ErrCommissionLTMinRate = errors.Register(ModuleName, 40, "commission cannot be less than min rate")
ErrUnbondingNotFound = errors.Register(ModuleName, 41, "unbonding operation not found")
ErrUnbondingOnHoldRefCountNegative = errors.Register(ModuleName, 42, "cannot un-hold unbonding operation that is not on hold")
ErrInvalidSigner = errors.Register(ModuleName, 43, "expected authority account as only signer for proposal message")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change, I know it is a bit out of scope of this PR but could you update it here too:

@tac0turtle tac0turtle added this pull request to the merge queue Jun 15, 2023
Merged via the queue into main with commit dcac757 Jun 15, 2023
@tac0turtle tac0turtle deleted the ap/gov-staking-dependencies branch June 15, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/staking should not depend on x/gov
5 participants