-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove x/gov module dependencies in x/staking #16567
Conversation
this is good :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@@ -50,4 +50,5 @@ var ( | |||
ErrCommissionLTMinRate = errors.Register(ModuleName, 40, "commission cannot be less than min rate") | |||
ErrUnbondingNotFound = errors.Register(ModuleName, 41, "unbonding operation not found") | |||
ErrUnbondingOnHoldRefCountNegative = errors.Register(ModuleName, 42, "cannot un-hold unbonding operation that is not on hold") | |||
ErrInvalidSigner = errors.Register(ModuleName, 43, "expected authority account as only signer for proposal message") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the change, I know it is a bit out of scope of this PR but could you update it here too:
cosmos-sdk/x/auth/keeper/msg_server.go
Line 27 in 629dc63
"expected gov account as only signer for proposal message; invalid authority; expected %s, got %s",
Description
Closes: #16472
ref: #13025
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change