Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/staking should not depend on x/gov #16472

Closed
Tracked by #13025
kocubinski opened this issue Jun 8, 2023 · 0 comments · Fixed by #16567
Closed
Tracked by #13025

x/staking should not depend on x/gov #16472

kocubinski opened this issue Jun 8, 2023 · 0 comments · Fixed by #16567
Assignees

Comments

@kocubinski
Copy link
Member

kocubinski commented Jun 8, 2023

Create a new error type instead of reusing the one in x/gov:

return nil, errorsmod.Wrapf(govtypes.ErrInvalidSigner, "invalid authority; expected %s, got %s", k.authority, msg.Authority)

Use a hard coded const string:

authority := authtypes.NewModuleAddress(govtypes.ModuleName)

authtypes.NewModuleAddress(govtypes.ModuleName).String(),

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 8, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Jun 8, 2023
@kocubinski kocubinski removed the needs-triage Issue that needs to be triaged label Jun 8, 2023
@atheeshp atheeshp self-assigned this Jun 14, 2023
@github-project-automation github-project-automation bot moved this from 📝 Todo to 👏 Done in Cosmos-SDK Jun 15, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants