-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: RFC 003: Language-independent Module Semantics & ABI #15410
Conversation
package cosmos.app.services.v1; | ||
|
||
// Store defines a service for interacting with key-value stores. | ||
service Store { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would we deal with kv and memory stores with this model? I can think of these approaches:
- find some way to address distinct
Store
services for kv and memory stores - add parameters to each request for the type of store
- decide not to support memory or transient stores at all
rpc Delete(DeleteRequest) returns (DeleteResponse); | ||
|
||
// Iterator queries the store for all keys between a certain start and end range. | ||
rpc Iterator(IteratorRequest) returns (stream IteratorResponse); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One challenge with doing this as a streaming service is that the server just starts pushing all the data to the client and I'm not finding any obvious way to cancel a server stream. Maybe that's okay if usage is documented clearly, but it's quite different from our current pull based iterator approach
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
2985947
to
41649a5
Compare
Ok to merge this as is? |
I'm not sure we should merge this with the proto files. Instead the proto files should be code snippets in the RFC. I'll make this change before we merge |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change