-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC: Create buf registry for each extracted module #13363
Comments
I love this idea! |
There's another thread where this got discussed but I think there needs to be a 1:1 correspondence between go modules and buf modules for versioning purposes. For each module we should (I think) only be pushing production proto files. The current state of buf is not right and contains a lot of unreleased stuff. |
Right, although, we could have a table too, like we are starting to do: https://github.com/cosmos/cosmos-sdk/tree/main/third_party/proto |
@julienrbrt @calbera is working on a version for berachain, will share with you and Marko once we get it working and clean. |
Intuitive or not, a single API module instead of each logical SDK module containing 2 go modules (API and Implementation) seems easier to reason and maintain to me. See this comment in the ADR 054 discussion for why I came to that conclusion. When we're closer to shipping SOA over an ABI (see #15410) I think it will make sense to make the changes described in this issue, but it seems a little early to me right now. |
Duplicated of #19503 |
Summary
Create a buf registry for each extracted module and move the proto module protos to their own folder.
Problem Definition
Currently, the modules' proto definition is located under https://github.com/cosmos/cosmos-sdk/tree/main/proto/cosmos.
From our DEV UX interview, this is not intuitive and does not align with the goal of a creating go module for SDK modules (#11899).
Proposal
We must ensure that pushing to the buf registry (https://buf.build/cosmos/cosmos-sdk) gives the same content.Verify, if is better to have each of the modules have their own buf repo.
proto/cosmos/auth
->x/auth/proto
.The text was updated successfully, but these errors were encountered: