Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Bump cosmossdk.io/math from 1.0.0-beta.4 to 1.0.0-beta.6 #14907

Closed
wants to merge 2 commits into from
Closed

build(deps): Bump cosmossdk.io/math from 1.0.0-beta.4 to 1.0.0-beta.6 #14907

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 4, 2023 •
edited
Loading

Bumps cosmossdk.io/math from 1.0.0-beta.4 to 1.0.0-beta.5.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner February 4, 2023 11:10
@dependabot dependabot bot added A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file labels Feb 4, 2023
@github-prbot github-prbot requested review from a team, alexanderbez and facundomedica and removed request for a team February 4, 2023 11:11
@github-actions github-actions bot added C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Rosetta Issues and PR related to Rosetta C:Store C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/tx C:x/upgrade labels Feb 4, 2023
@julienrbrt
Copy link
Member

Wow, adding collections in math (#14760), quite increase the dependency graph of all modules depending on math...

@tac0turtle
Copy link
Member

Yea I think we should rethink that dep. fine for now

julienrbrt
julienrbrt previously requested changes Feb 4, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for #14848.
Some dependencies update does not look right here.

@julienrbrt
Copy link
Member

julienrbrt commented Feb 4, 2023 •
edited
Loading

Yea I think we should rethink that dep. fine for now

I think it is not great, as core depends on math, which depends on collections.
But collections depends on core. I am not sure if it plays well when there is a breaking change.

@julienrbrt julienrbrt dismissed their stale review February 4, 2023 21:48

#14848 is not needed.

@julienrbrt
Copy link
Member

@dependabot recreate

@dependabot
build(deps): Bump cosmossdk.io/math from 1.0.0-beta.4 to 1.0.0-beta.5
aed04bb 
Bumps [cosmossdk.io/math](https://github.com/cosmos/cosmos-sdk) from 1.0.0-beta.4 to 1.0.0-beta.5.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md)
- [Commits](math/v1.0.0-beta.4...math/v1.0.0-beta.5)

---
updated-dependencies:
- dependency-name: cosmossdk.io/math
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/cosmossdk.io/math-1.0.0-beta.5 branch from 2c9acb3 to aed04bb Compare February 4, 2023 21:49
@github-actions github-actions bot removed C:CLI C:Hubl Tool: Hubl labels Feb 4, 2023
@github-actions github-actions bot removed C:x/evidence C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:x/circuit C:x/feegrant labels Feb 4, 2023
@github-actions github-actions bot added C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Rosetta Issues and PR related to Rosetta C:Store C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/tx C:x/upgrade labels Feb 4, 2023
@julienrbrt
Copy link
Member

#14912 will clean up the deps of math.
We will be able to tag math beta.6 and wait for dependabot to pick up that.

@julienrbrt julienrbrt closed this Feb 5, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 5, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/cosmossdk.io/math-1.0.0-beta.5 branch February 5, 2023 16:10
@julienrbrt julienrbrt restored the dependabot/go_modules/cosmossdk.io/math-1.0.0-beta.5 branch February 6, 2023 08:55
@julienrbrt julienrbrt reopened this Feb 6, 2023
@julienrbrt
Copy link
Member

@dependabot recreate

@github-prbot github-prbot requested a review from a team February 6, 2023 08:56
@julienrbrt julienrbrt changed the title build(deps): Bump cosmossdk.io/math from 1.0.0-beta.4 to 1.0.0-beta.5 build(deps): Bump cosmossdk.io/math from 1.0.0-beta.4 to 1.0.0-beta.6 Feb 6, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 6, 2023

Superseded by #14918.

@dependabot dependabot bot closed this Feb 6, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/cosmossdk.io/math-1.0.0-beta.5 branch February 6, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@facundomedica facundomedica Awaiting requested review from facundomedica

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Rosetta Issues and PR related to Rosetta C:Store C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/tx C:x/upgrade dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @tac0turtle