Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve go-update-dep-all.sh #14848

Closed
julienrbrt opened this issue Jan 30, 2023 · 1 comment
Closed

Improve go-update-dep-all.sh #14848

julienrbrt opened this issue Jan 30, 2023 · 1 comment
Assignees

Comments

@julienrbrt
Copy link
Member

          https://github.com/cosmos/cosmos-sdk/actions/runs/4047744533/jobs/6962151076

I think our script go mod update all is fundamentally broken, as it updates all the dependencies, regardless if they are actually needed or not.
Here, for instance, we use 0.47-rc1 so it should not have updated this to v1.4.4 (as there is no reason to)

Originally posted by @julienrbrt in #14838 (comment)

@julienrbrt julienrbrt self-assigned this Jan 30, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Jan 30, 2023
@julienrbrt julienrbrt moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jan 30, 2023
@julienrbrt julienrbrt moved this from 💪 In Progress to 📝 Todo in Cosmos-SDK Feb 1, 2023
@julienrbrt
Copy link
Member Author

Mea-culpa. After reading more about it, it seems not bad to upgrade indirect dependencies even if the direct dependencies do not require them. This is thus not an issue, and the update in #14908, not needed.

@julienrbrt julienrbrt closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2023
@github-project-automation github-project-automation bot moved this from 📝 Todo to 👏 Done in Cosmos-SDK Feb 4, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant