-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate store
and api
to CometBFT
#14899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
alexanderbez and
facundomedica
and removed request for
a team
February 3, 2023 15:01
20 tasks
alexanderbez
reviewed
Feb 3, 2023
alexanderbez
approved these changes
Feb 3, 2023
tac0turtle
approved these changes
Feb 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK thanks.
This was referenced Feb 7, 2023
19 tasks
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #14897, #14870
The goal of this PR is to migrate the Cosmos SDK modules that does not depend on the SDK to CometBFT.
Then a major version of these modules can be tagged, and the SDK can use it directly for its migration in #14897.
This will greatly limit the replace mess I was getting into.
Modules migrated here:
api
(by the mean of re-generating the proto and reverting anything outside ./api or ./store)make proto-gen
on main, until the migration is completed (in refactor!: migrate Cosmos SDK to CometBFT #14897 thus).store
SimApp that was using a replace tag for store, now use a pseudo version to the latest from main (prior to the renaming).
TODO:
After #14904 is merged, replace it by Comet in this PR.It was done in that PR directly.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change