refactor: remove .Type() and .Route() from msgs
#14751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/auth
C:x/authz
C:x/bank
C:x/consensus
C:x/crisis
C:x/distribution
amaury1093
reviewed
Jan 24, 2023
19 tasks
julienrbrt
changed the title
.Type() and .Route() from msgs
|
To backport or not to backport to v0.47.1, this is the question. There is no breaking change, neither feature change, only a cleanup. Except from one field removal in simulation. IMHO this is a good improvement. As we don't backport this for v0.47.0, I will just add the |
julienrbrt
commented
Jan 24, 2023
| @@ -160,14 +160,6 @@ type TestEvidence struct{} | |||
|
|
|||
| var _ exported.Evidence = &TestEvidence{} | |||
|
|
|||
| func (*TestEvidence) Route() string { | |||
There was a problem hiding this comment.
I can't delete this, as an evidence message has a route:
tac0turtle
reviewed
Jan 24, 2023
tac0turtle
approved these changes
Jan 24, 2023
19 tasks
|
@Mergifyio backport release/v0.47.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
(cherry picked from commit 8dbdfea) # Conflicts: # CHANGELOG.md # x/distribution/types/msg.go # x/evidence/types/msgs.go # x/gov/client/utils/query_test.go # x/gov/simulation/operations.go # x/gov/simulation/operations_test.go # x/gov/types/v1/msgs.go # x/staking/simulation/operations_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
.Type()and.Route()from all msgs and reflect that in the simulator.ref: #14728, #14753
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change