feat(core): add register services extension interface #14605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for registering services to the
cosmossdk.io/core/appmodule
API. Support can be added to main and the 0.47.x branch after this is merged.Note that this distinguishes between msg and query services based on the
cosmos.msg.v1.service
option. This can be discovered from file descriptors using either the official protobuf or our fork of gogo. In the future, we will likely want to support a third service type for internal ADR-033 services.My opinion is that this approach is a bit cleaner than needing to separate registration in golang methods or with a
Configurator
like we do now, but open to other approaches if people dislike it.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change