Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support core API service registration #14688

Closed
Tracked by #14683
aaronc opened this issue Jan 18, 2023 · 4 comments · Fixed by #15133
Closed
Tracked by #14683

Support core API service registration #14688

aaronc opened this issue Jan 18, 2023 · 4 comments · Fixed by #15133
Assignees

Comments

@aaronc
Copy link
Member

aaronc commented Jan 18, 2023

Support service registration as specified by #14605 in the module.Manager on main. This involves checking for the cosmos.msg.v1.service annotation to determine whether a service is a query or msg service.

Note that this will require parsing proto annotations for services which requires merged the FileDescriptors from gogo and protoreflect. https://github.com/cosmos/gogoproto/pull/37/files introduces the function that we can use to get the merged file descriptors. Then we should convert these descriptors to an instance of protoreflect.Files and get the service descriptor. The service name itself should come from the ServiceDesc argument passed to ServiceRegistrar.RegisterService. Then we check for the cosmos.msg.v1.service annotation using proto.GetExtension on ServiceDescriptor.Options with cosmossdk.io/api/cosmos/msg/v1.E_Service.

@facundomedica
Copy link
Member

@aaronc could you add more details on this? I can work on it but I don't know where to start. Thank you!

@aaronc
Copy link
Member Author

aaronc commented Feb 6, 2023

I added some more details to the description. Let me know if that's clear enough or not @facundomedica

@facundomedica facundomedica self-assigned this Feb 23, 2023
@facundomedica facundomedica moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Legacy Feb 23, 2023
@tac0turtle
Copy link
Member

@facundomedica is this closed?

@facundomedica
Copy link
Member

Yes, for some reason merging the pr didn't close it.

@github-project-automation github-project-automation bot moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Legacy Mar 14, 2023
@tac0turtle tac0turtle removed the Q1:2023 label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants