-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support core API service registration #14688
Comments
@aaronc could you add more details on this? I can work on it but I don't know where to start. Thank you! |
I added some more details to the description. Let me know if that's clear enough or not @facundomedica |
19 tasks
@facundomedica is this closed? |
Yes, for some reason merging the pr didn't close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Support service registration as specified by #14605 in the
module.Manager
onmain
. This involves checking for thecosmos.msg.v1.service
annotation to determine whether a service is a query or msg service.Note that this will require parsing proto annotations for services which requires merged the
FileDescriptor
s from gogo and protoreflect. https://github.com/cosmos/gogoproto/pull/37/files introduces the function that we can use to get the merged file descriptors. Then we should convert these descriptors to an instance ofprotoreflect.Files
and get the service descriptor. The service name itself should come from theServiceDesc
argument passed toServiceRegistrar.RegisterService
. Then we check for thecosmos.msg.v1.service
annotation usingproto.GetExtension
onServiceDescriptor.Options
withcosmossdk.io/api/cosmos/msg/v1.E_Service
.The text was updated successfully, but these errors were encountered: