Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support core API genesis in module manager #14582

Merged
merged 28 commits into from
Jan 27, 2023
Merged

feat: support core API genesis in module manager #14582

merged 28 commits into from
Jan 27, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jan 11, 2023 •
edited
Loading

Description

Follow-up to #14223, #14329, and #14333

Closes #14684

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-prbot github-prbot requested review from a team, amaury1093 and julienrbrt and removed request for a team January 11, 2023 19:49
@github-actions github-actions bot added C:CLI C:collections C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Rosetta Issues and PR related to Rosetta C:x/nft labels Jan 11, 2023
@sonarqubecloud
Copy link

[Cosmos SDK - Confix] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot removed C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:Rosetta Issues and PR related to Rosetta C:x/nft C:Confix Issues and PR related to Confix C:collections labels Jan 20, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 20, 2023
View reviewed changes
types/module/module.go Fixed Show fixed Hide fixed
aaronc
aaronc commented Jan 25, 2023
View reviewed changes
types/module/core_module.go Outdated Show resolved Hide resolved
types/module/module.go Outdated Show resolved Hide resolved
types/module/module.go Outdated Show resolved Hide resolved
aaronc
aaronc commented Jan 26, 2023
View reviewed changes
Copy link
Member Author

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now. Thanks @facundomedica !

@facundomedica facundomedica marked this pull request as ready for review January 26, 2023 14:21
@facundomedica facundomedica requested a review from a team as a code owner January 26, 2023 14:21
@github-prbot github-prbot requested a review from a team January 26, 2023 14:21
tac0turtle
tac0turtle reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job, left a question that is out of scope, but wondering if we can return errors and clean up some of the panic handling. Can be in a different pr as well

types/module/module.go Show resolved Hide resolved
@tac0turtle tac0turtle enabled auto-merge (squash) January 27, 2023 16:55
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 27, 2023
@tac0turtle tac0turtle merged commit aceadb0 into main Jan 27, 2023
@tac0turtle tac0turtle deleted the aaronc/core-api-genesis-impl2 branch January 27, 2023 17:14
@facundomedica facundomedica mentioned this pull request Jan 28, 2023
Merged
19 tasks
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
@aaronc @facundomedica
@tac0turtle @tsenart
feat: support core API genesis in module manager (cosmos#14582)
c1fbd13 
Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Marko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundomedica facundomedica facundomedica left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@amaury1093 amaury1093 Awaiting requested review from amaury1093

@julienrbrt julienrbrt Awaiting requested review from julienrbrt

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support core API genesis
4 participants
@aaronc @alexanderbez @facundomedica @tac0turtle