-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement basic core API genesis source and target #14329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not entirely sure how this plays into things, would be good to get some quick docs explaining things so reviewers can catch up instead of waiting for specific people
[Cosmos SDK] SonarCloud Quality Gate failed. |
Sorry the context is here: #14223. I should have linked that. I am trying to have everything documented in #12972 but I need to do a fair amount of updates to that to reflect the latest design and then hopefully we can merge at least as DRAFT or PROPOSED. Is the context in #14223 sufficient for now @tac0turtle ? Either way I can try to prioritize #12972 next week if that would be useful |
[Cosmos SDK - Core] Kudos, SonarCloud Quality Gate passed! |
(cherry picked from commit 5d62366)
Tagged |
Description
This implements a basic core API genesis source and target against
RawJSON
incore/genesis
. This is sufficient to start integrating into runtime/module manager after #14333 is merged.File based genesis streaming is being done in #13724 which is preferable but a bit more involved.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change