Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement basic core API genesis source and target #14329

Merged
merged 12 commits into from
Jan 5, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Dec 15, 2022

Description

This implements a basic core API genesis source and target against RawJSON in core/genesis. This is sufficient to start integrating into runtime/module manager after #14333 is merged.

File based genesis streaming is being done in #13724 which is preferable but a bit more involved.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc changed the title feat!: implement core API genesis feat!: implement core API genesis in module manager Dec 15, 2022
@aaronc aaronc added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Dec 15, 2022
@aaronc aaronc changed the title feat!: implement core API genesis in module manager feat!: implement basic core API genesis source and target Dec 15, 2022
@aaronc aaronc marked this pull request as ready for review December 15, 2022 23:26
@aaronc aaronc requested a review from a team as a code owner December 15, 2022 23:26
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not entirely sure how this plays into things, would be good to get some quick docs explaining things so reviewers can catch up instead of waiting for specific people

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

[Cosmos SDK] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@aaronc
Copy link
Member Author

aaronc commented Jan 4, 2023

not entirely sure how this plays into things, would be good to get some quick docs explaining things so reviewers can catch up instead of waiting for specific people

Sorry the context is here: #14223. I should have linked that.

I am trying to have everything documented in #12972 but I need to do a fair amount of updates to that to reflect the latest design and then hopefully we can merge at least as DRAFT or PROPOSED.

Is the context in #14223 sufficient for now @tac0turtle ? Either way I can try to prioritize #12972 next week if that would be useful

@aaronc aaronc enabled auto-merge (squash) January 5, 2023 14:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

[Cosmos SDK - Core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aaronc aaronc merged commit 5d62366 into main Jan 5, 2023
@aaronc aaronc deleted the aaronc/core-api-genesis-impl branch January 5, 2023 18:37
mergify bot pushed a commit that referenced this pull request Jan 5, 2023
@aaronc aaronc changed the title feat!: implement basic core API genesis source and target feat: implement basic core API genesis source and target Jan 11, 2023
@aaronc
Copy link
Member Author

aaronc commented Jan 11, 2023

Tagged core/v0.4.1 with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants