-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cosmovisor go install and upgrade path case sensitiveness
#12918
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ce75c1
fix: remove replace directive
julienrbrt 6395d64
chore: prepare cosmovisor 1.2.1 release
julienrbrt 92778f4
use version from go module (todo check releaser)
julienrbrt 2aedfb5
update changelog
julienrbrt 0e944fb
Merge branch 'main' into julien/fix-cosmovisor
julienrbrt e24505d
updates
julienrbrt 157b856
updates
julienrbrt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,20 +3,20 @@ | |
| `cosmovisor` is a small process manager for Cosmos SDK application binaries that monitors the governance module for incoming chain upgrade proposals. If it sees a proposal that gets approved, `cosmovisor` can automatically download the new binary, stop the current binary, switch from the old binary to the new one, and finally restart the node with the new binary. | ||
|
|
||
| <!-- TOC --> | ||
| - [Design](#design) | ||
| - [Contributing](#contributing) | ||
| - [Setup](#setup) | ||
| - [Installation](#installation) | ||
| - [Command Line Arguments And Environment Variables](#command-line-arguments-and-environment-variables) | ||
| - [Folder Layout](#folder-layout) | ||
| - [Usage](#usage) | ||
| - [Initialization](#initialization) | ||
| - [Detecting Upgrades](#detecting-upgrades) | ||
| - [Auto-Download](#auto-download) | ||
| - [Example: SimApp Upgrade](#example-simapp-upgrade) | ||
| - [Chain Setup](#chain-setup) | ||
|
|
||
|
|
||
| * [Design](#design) | ||
| * [Contributing](#contributing) | ||
| * [Setup](#setup) | ||
| * [Installation](#installation) | ||
| * [Command Line Arguments And Environment Variables](#command-line-arguments-and-environment-variables) | ||
| * [Folder Layout](#folder-layout) | ||
| * [Usage](#usage) | ||
| * [Initialization](#initialization) | ||
| * [Detecting Upgrades](#detecting-upgrades) | ||
| * [Auto-Download](#auto-download) | ||
| * [Example: SimApp Upgrade](#example-simapp-upgrade) | ||
| * [Chain Setup](#chain-setup) | ||
| * [Prepare Cosmovisor and Start the Chain](#prepare-cosmovisor-and-start-the-chain) | ||
| * [Update App](#update-app) | ||
|
|
||
| ## Design | ||
|
|
||
|
|
@@ -35,25 +35,27 @@ Cosmovisor is designed to be used as a wrapper for a `Cosmos SDK` app: | |
|
|
||
| Cosmovisor is part of the Cosmos SDK monorepo, but it's a separate module with it's own release schedule. | ||
|
|
||
| Release branches have the following format `release/cosmovisor/vA.B.x`, where A and B are a number (e.g. `release/cosmovisor/v0.1.x`). Releases are tagged using the following format: `cosmovisor/vA.B.C`. | ||
| Release branches have the following format `release/cosmovisor/vA.B.x`, where A and B are a number (e.g. `release/cosmovisor/v1.2.x`). Releases are tagged using the following format: `cosmovisor/vA.B.C`. | ||
|
|
||
| ## Setup | ||
|
|
||
| ### Installation | ||
|
|
||
| You can download Cosmovisor from the [Github releases](https://github.com/cosmos/cosmos-sdk/releases/tag/cosmovisor%2Fv1.2.1). | ||
|
|
||
| To install the latest version of `cosmovisor`, run the following command: | ||
|
|
||
| ```sh | ||
| go install github.com/cosmos/cosmos-sdk/cosmovisor/cmd/cosmovisor@latest | ||
| ``` | ||
|
|
||
| To install a previous version, you can specify the version. IMPORTANT: Chains that use Cosmos-SDK v0.44.3 or earlier (eg v0.44.2) and want to use auto-download feature MUST use Cosmovisor v0.1.0 | ||
| To install a previous version, you can specify the version. IMPORTANT: Chains that use Cosmos-SDK v0.44.3 or earlier (eg v0.44.2) and want to use auto-download feature MUST use `cosmovisor v0.1.0` | ||
|
|
||
| ```sh | ||
| go install github.com/cosmos/cosmos-sdk/cosmovisor/cmd/[email protected] | ||
| ``` | ||
|
|
||
| You can run `cosmovisor version` to check the Cosmovisor version (works only with Cosmovisor >1.1.0). | ||
| Run `cosmovisor version` to check the cosmovisor version. | ||
|
|
||
| You can also install from source by pulling the cosmos-sdk repository and switching to the correct version and building as follows: | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,10 @@ | ||
| # Cosmovisor v1.2.0 Release Notes | ||
|
|
||
| ### New Features | ||
|
|
||
| With the `cosmovisor init` command, all the necessary folders for using cosmovisor are automatically created. You do not need to manually symlink the chain binary anymore. | ||
|
|
||
| We've added a new configuration option: `DAEMON_RESTART_DELAY` (as env variable). When set, Cosmovisor will wait that delay between the node halt and backup. See the [README](https://github.com/cosmos/cosmos-sdk/blob/main/cosmovisor/README.md#command-line-arguments-and-environment-variables) file for more details. | ||
| # Cosmovisor v1.2.1 Release Notes | ||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * Fix Cosmovisor binary usage for pre-upgrade. Cosmovisor was using the wrong binary when running a `pre-upgrade` command. | ||
|
|
||
| * Fix failure when installing cosmovisor via `go install`. | ||
| * Fix plan path case sensitivity issue. | ||
|
|
||
| ### Changelog | ||
|
|
||
| For more details, please see the [CHANGELOG](https://github.com/cosmos/cosmos-sdk/blob/cosmovisor/v1.1.0/cosmovisor/CHANGELOG.md). | ||
| For more details, please see the [CHANGELOG](https://github.com/cosmos/cosmos-sdk/blob/cosmovisor/v1.2.1/cosmovisor/CHANGELOG.md). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"name": "Upgrade2", "info": "some info", "height": 125} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added in #11608, but I believe only the
EqualFoldaddition was necessary. Otherwise, we get #12915 bug.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So was not a bug, only not documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexanderbez should I revert that change and add docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julienrbrt yes pls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #12921