Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cosmovisor): updates docs about path name #12921

Merged
merged 10 commits into from
Aug 20, 2022
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 15, 2022

Description

Follow-up of #12918

  • Add documentation for normalized upgrade name path.
  • Update goreleaser as version is got at build.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Aug 15, 2022
@julienrbrt julienrbrt changed the title ci: prepare cosmovisor release docs: updates docs about path name Aug 18, 2022
@julienrbrt
Copy link
Member Author

Turns out, a few other changes needs to happen before releasing 1.2.1.
Waiting on #10925 for instance.
This PR only updates the documentation about the path name.

@julienrbrt julienrbrt marked this pull request as ready for review August 18, 2022 10:12
@julienrbrt julienrbrt requested a review from a team as a code owner August 18, 2022 10:12
@julienrbrt julienrbrt changed the title docs: updates docs about path name docs(cosmovisor): updates docs about path name Aug 18, 2022
@julienrbrt julienrbrt force-pushed the julien/release-cosmovisor branch from a34ce2e to a2eb8a3 Compare August 18, 2022 21:58
@julienrbrt
Copy link
Member Author

Depends on #12958 for fixing the submodules test.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #12921 (723aa71) into main (4fe7797) will decrease coverage by 0.09%.
The diff coverage is 60.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12921      +/-   ##
==========================================
- Coverage   55.87%   55.78%   -0.10%     
==========================================
  Files         646      659      +13     
  Lines       54895    55782     +887     
==========================================
+ Hits        30675    31120     +445     
- Misses      21762    22161     +399     
- Partials     2458     2501      +43     
Impacted Files Coverage Δ
baseapp/abci.go 64.09% <0.00%> (-0.33%) ⬇️
client/flags/flags.go 19.35% <0.00%> (-0.32%) ⬇️
client/rpc/status.go 66.66% <ø> (ø)
client/utils.go 34.92% <0.00%> (ø)
cosmovisor/scanner.go 82.00% <ø> (ø)
server/rosetta/client_online.go 1.35% <0.00%> (ø)
server/swagger.go 0.00% <0.00%> (ø)
simapp/app.go 82.66% <0.00%> (+3.55%) ⬆️
types/result.go 76.74% <ø> (ø)
x/auth/tx/query.go 0.00% <ø> (ø)
... and 61 more

@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 20, 2022
@mergify mergify bot merged commit dc361be into main Aug 20, 2022
@mergify mergify bot deleted the julien/release-cosmovisor branch August 20, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants