Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create .gitpod.yml #12662

Merged
merged 6 commits into from
Aug 15, 2022
Merged

feat: Create .gitpod.yml #12662

merged 6 commits into from
Aug 15, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jul 21, 2022

Description

Yesterday I made some changes to the standard dev env that we're using and to my surprise, they "just worked". That includes adding docker to the image so that we could do protocol buffer builds. It also has all the rocksdb tooling installed in the filesystem for those with container allergies.

Caveat: the rocksdb installed here is of the v7 variety. We would want to update our rocks library to grocksdb.

Nonetheless, this tooling represents a step forward. By clicking a little green button, developers can work on the sdk in a known-good environment.

image: ghcr.io/notional-labs/cosmos

That image is built here daily using cron via github actions and each build is observable.

https://github.com/notional-labs/containers/blob/master/cosmos/Dockerfile

@faddat faddat requested a review from a team as a code owner July 21, 2022 03:09
@faddat faddat changed the title Create .gitpod.yml feat: Create .gitpod.yml Jul 21, 2022
@julienrbrt
Copy link
Member

julienrbrt commented Jul 23, 2022

I think we didn't want to use an external docker image.

@marbar3778 cannot we just fork notional's container repository and use the image built for this gitpod config? It has the advantage to not add it on this repository like #11768 would do.

@faddat
Copy link
Contributor Author

faddat commented Jul 26, 2022

Works for me.

Just need a fork repo and then happy to maintain it from there.

Per #11768 -- I figure we've two choices:

  • move "all the things" here (I kind of like this approach. might streamline things some)
  • make a repo where we move the cosmos docker image build tooling.

@faddat
Copy link
Contributor Author

faddat commented Aug 8, 2022

This is getting relevant again, as is #11768

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is only gitpod specific

@tac0turtle tac0turtle merged commit f7310b3 into cosmos:main Aug 15, 2022
@julienrbrt julienrbrt mentioned this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants