Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yesterday I made some changes to the standard dev env that we're using and to my surprise, they "just worked". That includes adding docker to the image so that we could do protocol buffer builds. It also has all the rocksdb tooling installed in the filesystem for those with container allergies.
Caveat: the rocksdb installed here is of the v7 variety. We would want to update our rocks library to grocksdb.
Nonetheless, this tooling represents a step forward. By clicking a little green button, developers can work on the sdk in a known-good environment.
That image is built here daily using cron via github actions and each build is observable.
https://github.com/notional-labs/containers/blob/master/cosmos/Dockerfile
feat: Build own docker image and use ghcr #11768 is really just an attempt to build these images here, and contains most of the code found at:
https://github.com/notional-labs/containers/