Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent signing from wrong key in multisig #12548

Merged
merged 7 commits into from
Jul 14, 2022
Merged

fix: Prevent signing from wrong key in multisig #12548

merged 7 commits into from
Jul 14, 2022

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #12328

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #12548 (4bf4366) into main (63d484a) will decrease coverage by 0.04%.
The diff coverage is 38.29%.

❗ Current head 4bf4366 differs from pull request most recent head d81054c. Consider uploading reports for the commit d81054c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12548      +/-   ##
==========================================
- Coverage   65.23%   65.19%   -0.05%     
==========================================
  Files         693      694       +1     
  Lines       71798    71893      +95     
==========================================
+ Hits        46841    46868      +27     
- Misses      22326    22394      +68     
  Partials     2631     2631
Impacted Files Coverage Δ
x/auth/client/cli/tx_sign.go 0.00% <0.00%> (ø)
x/auth/client/testutil/suite.go 93.65% <100.00%> (+0.05%) ⬆️
x/auth/module.go 46.42% <0.00%> (ø)
x/auth/keeper/migrations.go 6.45% <0.00%> (ø)
x/distribution/migrations/v3/migrate.go
x/slashing/migrations/v3/migrate.go
x/crisis/migrations/v2/migrate.go
x/auth/migrations/v4/migrate.go
x/slashing/keeper/querier.go 16.94% <0.00%> (ø)
x/distribution/migrations/v046/migrate.go 60.00% <0.00%> (ø)
... and 5 more

@likhita-809 likhita-809 marked this pull request as ready for review July 13, 2022 06:16
@likhita-809 likhita-809 requested a review from a team as a code owner July 13, 2022 06:16
amaury1093
amaury1093 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the explanations in #12446

x/auth/client/cli/tx_sign.go Outdated Show resolved Hide resolved
@julienrbrt
Copy link
Member

julienrbrt commented Jul 14, 2022 •
edited
Loading

Testing the CLI locally...

julienrbrt
julienrbrt approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK!

@julienrbrt julienrbrt merged commit bbf020f into main Jul 14, 2022
@julienrbrt julienrbrt deleted the likhita/fix-multisig-key-2 branch July 14, 2022 16:55
@BrandonWeng BrandonWeng mentioned this pull request Jun 13, 2023
Merged
BrandonWeng added a commit to sei-protocol/sei-cosmos that referenced this pull request Jun 14, 2023
@BrandonWeng
[nice to have] multisig preventing signing with wrong key (#286)
19db353 
## Describe your changes and provide context
Doesn't seem to be absolutely necessary since it would just fail when
broadcasting, more of an UI improvement. We can wait until 3.0.4 is out
and then merging

Copying from: cosmos/cosmos-sdk#12548

## Testing performed to validate your change
unit tests
@LampardNguyen234 LampardNguyen234 mentioned this pull request Aug 15, 2023
Merged
@ulbqb ulbqb mentioned this pull request Mar 27, 2024
Merged
5 tasks
@mergify mergify bot mentioned this pull request Mar 28, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@anilcse anilcse Awaiting requested review from anilcse

@atheeshp atheeshp Awaiting requested review from atheeshp

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees

@julienrbrt julienrbrt

Labels
C:CLI C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent signing from wrong key in multisig
3 participants
@likhita-809 @julienrbrt @amaury1093