Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent signing from wrong key in multisig #12328

Closed
4 tasks
ebuchman opened this issue Jun 21, 2022 · 0 comments · Fixed by #12446 or #12548
Closed
4 tasks

Prevent signing from wrong key in multisig #12328

ebuchman opened this issue Jun 21, 2022 · 0 comments · Fixed by #12446 or #12548
Labels
C:Keys Keybase, KMS and HSMs T: Client UX

Comments

@ebuchman
Copy link
Member

Summary

When signing a multisig tx, you are required to provide the multisig address (--multisig) and the key you are signing with (--from), but there's no check that the key is actually part of the multisig. This makes it very easy to accidentally sign with the wrong key and only figure it out when you try to broadcast the invalid tx that includes a signature from a key thats not in the multisig.

Would be amazing if the tx sign command could somehow check if the key you are trying to sign with is actually part of the multisig. This would presumably require access to the pubkey of the multisig, which the user should have anyways, and it should then be straightforward to check that the pubkey associated with the --from is in the multisig.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Keys Keybase, KMS and HSMs T: Client UX
Projects
None yet
2 participants