Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update license copyright #12542

Merged
merged 5 commits into from
Jul 13, 2022
Merged

chore: update license copyright #12542

merged 5 commits into from
Jul 13, 2022

Conversation

robert-zaremba
Copy link
Collaborator

Description

Ref: #10576 (comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba added S:proposed backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release labels Jul 12, 2022
@robert-zaremba robert-zaremba requested a review from a team as a code owner July 12, 2022 17:29
@julienrbrt
Copy link
Member

julienrbrt commented Jul 12, 2022

Do you know if the first line of the license breaks GitHub License detection?
It would be nice if GitHub can detect it properly (like there https://github.com/golang/go/blob/master/LICENSE)

LICENSE Outdated Show resolved Hide resolved
@tac0turtle tac0turtle removed the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Jul 13, 2022
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to backport

@robert-zaremba
Copy link
Collaborator Author

Do you know if the first line of the license breaks GitHub License detection?

@julienrbrt good find. Yes, the header is not correct and it breaks the auto detection. I've updated the header.

We can check if the license detector works using:

gh api \
  -H "Accept: application/vnd.github+json" \
  /repos/cosmos/cosmos-sdk/license

Which currently returns:

 ...
  "license": {
    "key": "other",
    "name": "Other",
    "spdx_id": "NOASSERTION",
    "url": null,
    "node_id": "MDc6TGljZW5zZTA="
  }

Note: key should have something like apache-2

@robert-zaremba
Copy link
Collaborator Author

after merging this we can check if this fixes the github autodetection.

@robert-zaremba robert-zaremba added A:automerge Automatically merge PR once all prerequisites pass. and removed S:proposed labels Jul 13, 2022
@mergify mergify bot merged commit d5d2aa7 into main Jul 13, 2022
@mergify mergify bot deleted the robert/license branch July 13, 2022 10:19
@julienrbrt
Copy link
Member

after merging this we can check if this fixes the github autodetection.

It fixed it https://github.com/cosmos/cosmos-sdk/blob/main/LICENSE 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants