Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update license copyright notice #10576

Closed
wants to merge 1 commit into from
Closed

Conversation

robert-zaremba
Copy link
Collaborator

Description

Updating the license copyright notice.

When copying the license to QR repository I noticed that we should update the copyright section.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ValarDragon
Copy link
Contributor

What does "Copyright Cosmos" even mean. Is that a legal entity? Is that a blockchain? Is that a collective of chains?

If it should refer to the cosmos hub token holder governance, it should say that.

@ValarDragon ValarDragon requested a review from zmanian November 19, 2021 06:31
@hxrts
Copy link
Contributor

hxrts commented Nov 19, 2021

Please wait on this until we've had time to discuss with legal. Agree a change is appropriate but need to better understand implications first.

@hxrts hxrts requested a review from mariapao November 19, 2021 09:15
@tac0turtle
Copy link
Member

closing this till there is a discussion with legal. We can reopen when it ready to be merged.

@tac0turtle tac0turtle closed this Nov 22, 2021
@robert-zaremba
Copy link
Collaborator Author

I created this PR to start a discussion about what copyrights we should use.

We can also consider re-licensing. I'm big supporter of Mozilla Public License v2 (MPL 2.0).

The MPL is a simple copyleft license. The MPL's "file-level" copyleft is designed to encourage contributors to share modifications they make to your code, while still allowing them to combine your code with code under other licenses (open or proprietary) with minimal restrictions.

See more at: https://www.mozilla.org/en-US/MPL/2.0/FAQ/

@ebuchman
Copy link
Member

The copyright is owned by the contributors. It should just say “Copyright Cosmos-SDK Authors” or something very simple.

Changing licenses seems like a non-starter.

@alexanderbez alexanderbez deleted the robert/license branch April 22, 2022 13:41
@robert-zaremba robert-zaremba restored the robert/license branch July 12, 2022 17:25
@robert-zaremba
Copy link
Collaborator Author

Updating to Copyright Cosmos-SDK Authors

@robert-zaremba
Copy link
Collaborator Author

Oh, seams I can't reopen the PR, will create a new PR

@robert-zaremba robert-zaremba deleted the robert/license branch July 12, 2022 17:26
mergify bot pushed a commit that referenced this pull request Jul 13, 2022
## Description

Ref: #10576 (comment)


---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants