-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 579 #916
Fix issue 579 #916
Conversation
Thanks for this! It looks like you have some failing unit tests. If you could resolve them, I would appreciate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This is packaged up in a really clean way, I like it. Like Danny says, if you could update the unit tests that'd be awesome. Then I think we're golden and this gets a thumbs up from me 👍 .
Thanks for your comments. I fix unit tests and try again. |
…t on free rotate. The rectanglur and elliptical ROI tools now correctly rotate with the image. cornerstonejs#579
Thanks for this @daniel2101 ! Added one commit so this change will cut a new release. |
Codecov Report
@@ Coverage Diff @@
## master #916 +/- ##
==========================================
- Coverage 11.78% 11.73% -0.05%
==========================================
Files 218 218
Lines 7129 7156 +27
Branches 1120 1124 +4
==========================================
Hits 840 840
- Misses 5318 5341 +23
- Partials 971 975 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #916 +/- ##
==========================================
- Coverage 11.78% 11.73% -0.05%
==========================================
Files 218 218
Lines 7129 7156 +27
Branches 1120 1124 +4
==========================================
Hits 840 840
- Misses 5318 5341 +23
- Partials 971 975 +4
Continue to review full report at Codecov.
|
🎉 This PR is included in version 3.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @daniel2101 for this cool code contribution! |
I've put up a pull request to add @daniel2101! 🎉 |
What kind of change does this PR introduce? Bug fix
What is the current behavior? Issue when we mix Rotate with BrushTool, EllipseRoiTool and RectangleRoiTool. #579
What is the new behavior (if this is a feature change)? Bug fix, correct rotation
Does this PR introduce a breaking change? No
Other information: