Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 579 #916

Merged
merged 4 commits into from
Apr 30, 2019
Merged

Fix issue 579 #916

merged 4 commits into from
Apr 30, 2019

Conversation

daniel2101
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@dannyrb dannyrb requested review from dannyrb and JamesAPetts April 26, 2019 03:01
@dannyrb
Copy link
Member

dannyrb commented Apr 26, 2019

Thanks for this! It looks like you have some failing unit tests. If you could resolve them, I would appreciate it.

Copy link
Member

@JamesAPetts JamesAPetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is packaged up in a really clean way, I like it. Like Danny says, if you could update the unit tests that'd be awesome. Then I think we're golden and this gets a thumbs up from me 👍 .

@daniel2101
Copy link
Author

Thanks for your comments. I fix unit tests and try again.

Salvador Daniel Pelayo and others added 2 commits April 26, 2019 10:26
…t on free rotate.

The rectanglur and elliptical ROI tools now correctly rotate with the image.

cornerstonejs#579
@JamesAPetts
Copy link
Member

Thanks for this @daniel2101 ! Added one commit so this change will cut a new release.

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #916 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   11.78%   11.73%   -0.05%     
==========================================
  Files         218      218              
  Lines        7129     7156      +27     
  Branches     1120     1124       +4     
==========================================
  Hits          840      840              
- Misses       5318     5341      +23     
- Partials      971      975       +4
Impacted Files Coverage Δ
src/tools/annotation/RectangleRoiTool.js 16.52% <0%> (ø) ⬆️
src/util/pointProjector.js 0% <0%> (ø) ⬆️
src/drawing/drawEllipse.js 0% <0%> (ø) ⬆️
src/tools/annotation/EllipticalRoiTool.js 18.86% <0%> (ø) ⬆️
src/drawing/drawRect.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c347ab...b1fb8e7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #916 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   11.78%   11.73%   -0.05%     
==========================================
  Files         218      218              
  Lines        7129     7156      +27     
  Branches     1120     1124       +4     
==========================================
  Hits          840      840              
- Misses       5318     5341      +23     
- Partials      971      975       +4
Impacted Files Coverage Δ
src/tools/annotation/RectangleRoiTool.js 16.52% <0%> (ø) ⬆️
src/util/pointProjector.js 0% <0%> (ø) ⬆️
src/drawing/drawEllipse.js 0% <0%> (ø) ⬆️
src/tools/annotation/EllipticalRoiTool.js 18.86% <0%> (ø) ⬆️
src/drawing/drawRect.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c347ab...b1fb8e7. Read the comment docs.

@JamesAPetts JamesAPetts merged commit 07fa8df into cornerstonejs:master Apr 30, 2019
@dannyrb
Copy link
Member

dannyrb commented Apr 30, 2019

🎉 This PR is included in version 3.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dannyrb
Copy link
Member

dannyrb commented Apr 30, 2019

@all-contributors please add @daniel2101 for this cool code contribution!

@allcontributors
Copy link
Contributor

@dannyrb

I've put up a pull request to add @daniel2101! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants