Issue when we mix Rotate with BrushTool, EllipseRoiTool and RectangleRoiTool.

[JamesAPetts]

Steps to reproduce:

• Open global example
• Paint with the brush, draw a circlular ROI and an rectangluar ROI.
• Select Rotate tool and rotate the image something like 45 degrees. All three tools are distorted.
• Select Brush and try to use the tool. It will paint in the wrong place.
• New Rectangles and ellipses can be drawn 'correctly' with the tilted angle, but when you rotate the image back, you don't get back what you intended to mark up.

For strict 90 degree rotations, the rectangle and circle stay intact. This is because the geometry is based off two control points, which reference a certain pixel, and are safe to rotation. Tools like angle, length, freehand and probe that only draw straight lines between control points are safe to rotation.

The brush renders incorrectly even with 90 degree rotations (try drawing around an object in the demo), and you cannot draw in the correct place. It seems to do some strange image flip, if you compare a rotate of a circular brush to an overlayed circular roi tool.

Thanks @galelis

[JamesAPetts]

Ok after some further deliberation with @swederik, I've come to the conclusion that the issues with the brush and the rois is identical, the only difference being that the brush segmentation isn't rotationally symmetric.

Let me demonstrate, I've drawn 4 'segmentations' that fill up the canvas, as well as a rect and circle:

Then rotating ~30 degrees clockwise, the image gets skewed:

It dissapears at exactly 45 degrees, at around 60 degrees the control points have flipped sides, and the image is rendered within those control points to the canvas:

At 90 degrees the circle and rectangle look as expected after a rotation, because they are rotationally symmetric. The brush tool isn't flipped as its control nodes are rotated, then the image is rendered within these nodes, so it looks the same as it did unrotated.

What is really needed is a rotation of the entire canvas. I'm going to play with transform of the tools in image rendered, but I feel this is a more fundamental issue. Tagging @chafey , as @swederik said you were the author of the rotation stuff in cornerstone core, do you have any insight into how we could fix this issue globally?

Thanks,
J

[JamesAPetts]

Just confirming I'm now working on this.

[JamesAPetts]

This is fixed for the brush layer for arbitrary rotations + h/v flips in #755.

The issues with the elliptical and rectangular ROI tools remain for now.

[JamesAPetts]

Thanks @daniel2101 for fixing the rectangles and ellipses in #916 ! :)

[prateekghosh]

Hey can you please help me out of removing the brush tool data from the canvas I didn't find solution for that.