Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1101: Updating the perpendicular line handles when done creating #1102

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

brunoalvesdefaria
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    BidirectionalTool sometimes not perpendicular on its creation #1101

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    N/A

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #1102 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
- Coverage   18.98%   18.97%   -0.01%     
==========================================
  Files         282      282              
  Lines        8403     8404       +1     
  Branches     1422     1422              
==========================================
  Hits         1595     1595              
- Misses       5652     5653       +1     
  Partials     1156     1156
Impacted Files Coverage Δ
.../annotation/bidirectionalTool/addNewMeasurement.js 2.38% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af903bb...598f239. Read the comment docs.

@dannyrb
Copy link
Member

dannyrb commented Oct 11, 2019

LGTM 👍

@dannyrb dannyrb merged commit 4d36462 into master Oct 11, 2019
@dannyrb
Copy link
Member

dannyrb commented Oct 11, 2019

🎉 This PR is included in version 4.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brunoalvesdefaria brunoalvesdefaria deleted the issue-1101 branch October 11, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants