Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Username/Email Login Identifier #1291

Merged
merged 8 commits into from
Feb 19, 2020

Conversation

solverat
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #1290

See #1290 for discussion.

Copy link
Member

@dpfaffenbauer dpfaffenbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@dpfaffenbauer dpfaffenbauer added this to the 2.2.0 milestone Feb 18, 2020
@dpfaffenbauer dpfaffenbauer linked an issue Feb 18, 2020 that may be closed by this pull request
dpfaffenbauer
dpfaffenbauer previously approved these changes Feb 18, 2020
@dpfaffenbauer dpfaffenbauer merged commit e30f278 into coreshop:master Feb 19, 2020
@solverat solverat deleted the login_type branch February 19, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow email or username in ObjectUserProvider
3 participants