Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow email or username in ObjectUserProvider #1290

Closed
solverat opened this issue Feb 18, 2020 · 0 comments · Fixed by #1291
Closed

Allow email or username in ObjectUserProvider #1290

solverat opened this issue Feb 18, 2020 · 0 comments · Fixed by #1291
Assignees
Milestone

Comments

@solverat
Copy link
Contributor

solverat commented Feb 18, 2020

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no

Currently, only email addresses are allowed to use for login. We should allow login via username or email address. Introducing a new config flag should fix this.

Config

core_shop_customer:
    login_identifier: 'email' # this is the default value

Security

Inject parameter and switch between findCustomerByEmail and findCustomerByUsername

Improvements

  • Eventlistener: Add pre-save listener to customer object: If isGuest is unchecked, check if username or email already has been taken.
  • Login Form Label: Use username or email address depending on given setting (Currently we're using "username" as label, which is misleading since we actually need the email address)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant