Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: drop renameio dependency #39

Merged
merged 1 commit into from
Jan 25, 2022
Merged

stream: drop renameio dependency #39

merged 1 commit into from
Jan 25, 2022

Conversation

bgilbert
Copy link
Contributor

It doesn't build on Windows. Hand-implement tempfile handling instead.

Fixes #38.

cc @cgwalters

@bgilbert bgilbert mentioned this pull request Jan 18, 2022
@bgilbert bgilbert requested review from cgwalters and jlebon January 19, 2022 15:19
jlebon
jlebon previously approved these changes Jan 25, 2022
stream/artifact_utils.go Show resolved Hide resolved
It doesn't build on Windows.  Hand-implement tempfile handling instead.

Fixes #38.
@bgilbert bgilbert merged commit 03f2703 into coreos:main Jan 25, 2022
@bgilbert bgilbert deleted the renameio branch January 25, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows build support
2 participants