Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows build support #38

Closed
Luap99 opened this issue Jan 18, 2022 · 2 comments · Fixed by #39
Closed

windows build support #38

Luap99 opened this issue Jan 18, 2022 · 2 comments · Fixed by #39

Comments

@Luap99
Copy link

Luap99 commented Jan 18, 2022

PR #18 added https://github.com/google/renameio as dependency however this is not supported on windows

I wonder is renameio really needed here? Shouldn't be a simple tmpfile + rename be good enough for this use case. In the end this is just a download if the file gets corrupted we can download again.
@Luap99 Luap99 mentioned this issue Jan 18, 2022
Merged
@bgilbert bgilbert mentioned this issue Jan 18, 2022
Merged
@bgilbert
Copy link
Contributor

Ah yeah, thanks for the report. Fix in #39.

@bgilbert
Copy link
Contributor

#40 adds CI for Windows and macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stream: drop renameio dependency
2 participants
@bgilbert @Luap99