Require ostree 2017.5 📆 #740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 14, 2017
This is another way to partially address coreos#740 We should also likely have a `fedora/25/atomic/testing` image.
jlebon
reviewed
Apr 18, 2017
There was a problem hiding this comment.
Might as well wait for the imminent ostree build with the fix for ostreedev/ostree#799.
tests/vmcheck/overlay.sh
Outdated
| @@ -58,7 +58,17 @@ rm vmcheck -rf | |||
| ostree checkout $commit vmcheck --fsync=0 | |||
| # ✀✀✀ BEGIN hack for https://github.com/projectatomic/rpm-ostree/pull/693 ✀✀✀ | |||
| rm -f vmcheck/usr/etc/{.pwd.lock,passwd-,group-,shadow-,gshadow-,subuid-,subgid-} | |||
| # ✀✀✀ END hack for https://github.com/projectatomic/rpm-ostree/pull/693 ✀✀✀ | |||
| # ✀✀✀ END hack for https://github.com/projectatomic/rpm-ostree/pull/642 ✀✀✀ | |||
There was a problem hiding this comment.
This should still point at #693, right?
.redhat-ci.yml
Outdated
| @@ -101,6 +108,7 @@ tests: | |||
| - > | |||
| docker run --privileged -v $(pwd):/srv/code --rm | |||
| projectatomic/rpm-ostree-tester /bin/sh -c " | |||
| yum -y install https://kojipkgs.fedoraproject.org//packages/ostree/2017.4/2.fc25/x86_64/ostree-2017.4-2.fc25.x86_64.rpm https://kojipkgs.fedoraproject.org//packages/ostree/2017.4/2.fc25/x86_64/ostree-devel-2017.4-2.fc25.x86_64.rpm https://kojipkgs.fedoraproject.org//packages/ostree/2017.4/2.fc25/x86_64/ostree-libs-2017.4-2.fc25.x86_64.rpm && | |||
There was a problem hiding this comment.
You should be able to split this on multiple lines to make it more legible, even with indentation if you'd like.
This is preparatory for future changes which will make use the newer sysroot writing API. But in this change, we can drop all of our version ifdef'd code.
cgwalters
force-pushed
the
require-ostree-2017.4
branch
from
1ddace9 to
ad5ce6c
Compare
|
Reworked for comments and updated to 2017.5 ⬆️ |
|
Grrr sorry, notification emails are not going through for some reason. |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparatory for future changes which will make use the newer sysroot
writing API. But in this change, we can drop all of our version ifdef'd code.
(Breaking this out of since it's harder than I thought #709 - in fact astonishing levels of pain 😢 )