compose: Delete /usr/etc/passwd- (and the other variants) #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
compose-delete-lock-files
branch
from
b8eef11 to
11c13ea
Compare
There's no point to shipping these backup files in the base tree. We already had code to delete them for the package layering case where they caused active harm. At the point we added that code we really should have *also* changed treecompose to delete them. Better late than never. The reason I'm doing this now is because having them in the base tree causes `ex livefs` to spuriously think that layering a package that *doesn't* change `/etc` as if it does, because the layering code deletes the backup files.
cgwalters
force-pushed
the
compose-delete-lock-files
branch
from
11c13ea to
32a9059
Compare
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 18, 2017
Until we land <coreos#693> and it makes its way into all of our streams. Necessary for livefs.
|
☀️ Test successful - status-atomicjenkins |
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 22, 2017
Until we land <coreos#693> and it makes its way into all of our streams. Necessary for livefs.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 22, 2017
Until we land <coreos#693> and it makes its way into all of our streams. Necessary for livefs.
Closed
miabbott
added a commit
to miabbott/atomic-host-tests
that referenced
this pull request
Jun 13, 2017
New composes done with `rpm-ostree` will have the backups of the `passwd` removed, per coreos/rpm-ostree#693. This will cause the `selinux_verify` role to fail. Since we are already checking the primary file, consensus says that it is safe to remove the checks on that particular backup, as well as the other backups of `group`, `shadow`, and `gshadow`.
miabbott
pushed a commit
to projectatomic/atomic-host-tests
that referenced
this pull request
Jun 13, 2017
New composes done with `rpm-ostree` will have the backups of the `passwd` removed, per coreos/rpm-ostree#693. This will cause the `selinux_verify` role to fail. Since we are already checking the primary file, consensus says that it is safe to remove the checks on that particular backup, as well as the other backups of `group`, `shadow`, and `gshadow`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no point to shipping these backup files in the base tree. We already had
code to delete them for the package layering case where they caused active harm.
At the point we added that code we really should have also changed treecompose
to delete them. Better late than never.
The reason I'm doing this now is because having them in the base tree causes
ex livefsto spuriously think that layering a package that doesn't change/etcas if it does, because the layering code deletes the backup files.