rust: Freeze rand crate to v0.6.1 #1778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent dep bump caused rand to jump to v0.6.5, which pulled in `fuchsia-cprng`. Sadly, the cargo version we're frozen on chokes on it because its manifest makes use of the `edition` keyword, which wasn't stabilized yet. Let's just freeze the problematic crate for now. We should be able to bump our Rust toolchain soon-ish. (Note this commit also does some other minor crate bumps as a result of regenerating the lockfile to prune away `fuchsia-cprng`.) Closes: coreos#1777
Otherwise, we're not testing everything. E.g. the cbindgen bits.
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 7, 2019
The recent dep bump caused rand to jump to v0.6.5, which pulled in `fuchsia-cprng`. Sadly, the cargo version we're frozen on chokes on it because its manifest makes use of the `edition` keyword, which wasn't stabilized yet. Let's just freeze the problematic crate for now. We should be able to bump our Rust toolchain soon-ish. (Note this commit also does some other minor crate bumps as a result of regenerating the lockfile to prune away `fuchsia-cprng`.) Closes: #1777 Closes: #1778 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 7, 2019
Otherwise, we're not testing everything. E.g. the cbindgen bits. Closes: #1778 Approved by: cgwalters
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 7, 2019
Otherwise, we're not testing everything. E.g. the cbindgen bits. Closes: #1778 Approved by: cgwalters
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent dep bump caused rand to jump to v0.6.5, which pulled in
fuchsia-cprng. Sadly, the cargo version we're frozen on chokes on itbecause its manifest makes use of the
editionkeyword, which wasn'tstabilized yet.
Let's just freeze the problematic crate for now. We should be able to
bump our Rust toolchain soon-ish.
(Note this commit also does some other minor crate bumps as a result of
regenerating the lockfile to prune away
fuchsia-cprng.)Closes: #1777