-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cbindgen failures after bumping Rust dependencies #1777
Comments
OK, so one obvious thing here is that CI is using |
Hmm nope, even internal fails:
|
OK, so I think this is due to
It works fine with the latest cargo. So I think CI is just not hitting this because it's pulling in cargo from the Fedora repos, while the rust check we have doesn't actually go through the cbindgen path. Will fix. |
The recent dep bump caused rand to jump to v0.6.5, which pulled in `fuchsia-cprng`. Sadly, the cargo version we're frozen on chokes on it because its manifest makes use of the `edition` keyword, which wasn't stabilized yet. Let's just freeze the problematic crate for now. We should be able to bump our Rust toolchain soon-ish. (Note this commit also does some other minor crate bumps as a result of regenerating the lockfile to prune away `fuchsia-cprng`.) Closes: coreos#1777
The recent dep bump caused rand to jump to v0.6.5, which pulled in `fuchsia-cprng`. Sadly, the cargo version we're frozen on chokes on it because its manifest makes use of the `edition` keyword, which wasn't stabilized yet. Let's just freeze the problematic crate for now. We should be able to bump our Rust toolchain soon-ish. (Note this commit also does some other minor crate bumps as a result of regenerating the lockfile to prune away `fuchsia-cprng`.) Closes: #1777 Closes: #1778 Approved by: cgwalters
The recent dep bump caused rand to jump to v0.6.5, which pulled in `fuchsia-cprng`. Sadly, the cargo version we're frozen on chokes on it because its manifest makes use of the `edition` keyword, which wasn't stabilized yet. Let's just freeze the problematic crate for now. We should be able to bump our Rust toolchain soon-ish. (Note this commit also does some other minor crate bumps as a result of regenerating the lockfile to prune away `fuchsia-cprng`.) Closes: coreos#1777
Now that our minimum Rust toolchain version was bumped, we can bump all our deps to the latest and drop the frozen `rand` version that was done for coreos#1777.
Still tracking this down, but it seems like I can no longer build git master from scratch after 3f722b5. It fails on the step to call
cbindgen
to generate the header:The text was updated successfully, but these errors were encountered: