This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
grub: drop 02_ignition_firstboot #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that FCOS no longer regenerates GRUB2 configs, this logic was moved to the static one in coreos-assembler: coreos/coreos-assembler#616
|
We do still want this for now on architectures which still use Anaconda (and hence don't use the static GRUB2 config). And it doesn't hurt on arches which did the move already, so we can leave it in for now. |
|
I think we can get this in now, right? FCOS doesn't use Anaconda anymore for any platform. |
This was referenced Jan 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that FCOS no longer regenerates GRUB2 configs, this logic was moved
to the static one in coreos-assembler:
coreos/coreos-assembler#616