Makefile: New file implementing make install
#106
Conversation
| install -D -t $(DESTDIR)/usr/lib/dracut/modules.d/$${bn} $$x/*; \ | ||
| done | ||
| install -D -t $(DESTDIR)/usr/lib/systemd/system systemd/* | ||
| install -D -t $(DESTDIR)/etc/grub.d grub/* |
There was a problem hiding this comment.
Should we still be carrying this?
There was a problem hiding this comment.
See #91
(So currently yes)
Makefile
Outdated
| @@ -0,0 +1,7 @@ | |||
| install: | |||
There was a problem hiding this comment.
Minor: if there's no build step, I tend to add something like:
.PHONY: all
all:
@echo "No build step."at the top so that (1) a make all still Just Works in an automated context, and (2) a pure make won't actually do a make install.
Let's maybe also add a .PHONY for install?
There was a problem hiding this comment.
Thanks, excellent feedback! Updated ⬇️
|
should we require that someone provide DESTDIR so that we don't accidentally pollute a users system? |
No, because that'd break |
|
one remaining comment: #106 (comment) |
See https://github.com/cgwalters/build-api With this for example, we can just have the Fedora spec file do `make install DESTDIR=$RPM_BUILD_ROOT` just like everything else; helping to ensure that as much logic as possible remains upstream. Mainly I want this for hacking so I can just `make install DESTDIR=/srv/walters/fcos/overrides/rootfs` without building an RPM or copying files manually.
|
will let @jlebon do final review/merge |
Following coreos/ignition-dracut#106 add a default `make install` rule that honors `DESTDIR`. Main motivation is hacking on ignition in a unified way with ostree, ignition-dracut and other projects using coreos-assembler.
Following coreos/ignition-dracut#106 add a default `make install` rule that honors `DESTDIR`. Main motivation is hacking on ignition in a unified way with ostree, ignition-dracut and other projects using coreos-assembler.
Following coreos/ignition-dracut#106 add a default `make install` rule that honors `DESTDIR`. Main motivation is hacking on ignition in a unified way with ostree, ignition-dracut and other projects using coreos-assembler.
Following coreos/ignition-dracut#106 add a default `make install` rule that honors `DESTDIR`. Main motivation is hacking on ignition in a unified way with ostree, ignition-dracut and other projects using coreos-assembler. (Backport of coreos#858)
Same rationale as coreos/ignition-dracut#106 See https://github.com/cgwalters/build-api With this for example, we can just have the RHEL spec file do `make install DESTDIR=$RPM_BUILD_ROOT` just like everything else; helping to ensure that as much logic as possible remains upstream.
See https://github.com/cgwalters/build-api
With this for example, we can just have the Fedora spec file do
make install DESTDIR=$RPM_BUILD_ROOTjust like everything else;helping to ensure that as much logic as possible remains upstream.
Mainly I want this for hacking so I can just
make install DESTDIR=/srv/walters/fcos/overrides/rootfswithout building an RPM or copying files manually.