manifests/jenkins: bump jnlp memory to 512Mi #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've already rolled this out in CoreOS CI to test it. If coreos/coreos-assembler#3375 and coreos/coreos-assembler#3374 come back happy, let's consider it fixed and merge this. |
By default, the jnlp container has a memory request of 256Mi and no memory limit. In 9eed927 ("manifests/jenkins: set resource limits and requests for jnlp container"), we added an explicit memory limit so that we don't inherit the default 10G memory limit from the limitrange in the RHCOS OpenShift project. We set it to 256Mi since that's what the default memory *request* was, but it's too little as a hard limit. Most of the time, the jnlp unexplicably dies, but at least once, I saw it fail with: ``` java.lang.OutOfMemoryError: unable to create native thread: possibly out of memory or process/resource limits reached ``` Bump it to 512Mi. And also bump the request since in this project we try to have requests match what the pod actually needs. While we're here, add a comment about why we set these values. Fixes coreos/coreos-assembler#3372.
jlebon
force-pushed
the
pr/bump-jnlp-limit
branch
from
72d6813 to
ad4a38e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the jnlp container has a memory request of 256Mi and no
memory limit. In 9eed927 ("manifests/jenkins: set resource limits and
requests for jnlp container"), we added an explicit memory limit so that
we don't inherit the default 10G memory limit from the limitrange in
the RHCOS OpenShift project. We set it to 256Mi since that's what the
default memory request was, but it's too little as a hard limit. Most
of the time, the jnlp unexplicably dies, but at least once, I saw it
fail with:
Bump it to 512Mi. And also bump the request since in this project we try
to have requests match what the pod actually needs.
While we're here, add a comment about why we set these values.
Fixes coreos/coreos-assembler#3372.