mantle/kola: fix systemd generator failure detection #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Feb 23, 2023
Apparently it can start with `systemd` or `sd-execu`. Here is an example: ``` Feb 23 21:50:38.240188 /usr/lib/systemd/system-generators/coreos-platform-chrony: line 44: /etc/sysconfig/network: Read-only file system Feb 23 21:50:38.240195 (sd-execu[1020]: /usr/lib/systemd/system-generators/coreos-platform-chrony failed with exit status 1. ``` I think the difference may be whether the failure happens in the initramfs or the real root. Let's make our regex matching more generic and also handle more cases [1]. [1] https://github.com/systemd/systemd/blob/dafb406383610cc631345815919fd8a77ee0c4dc/src/basic/process-util.c#L663-L679
dustymabe
force-pushed
the
dusty-enhance-generator-failure-detection
branch
from
8426764 to
6bf12d8
Compare
|
Ahhh, looks like CI hit #3372 again. Will have to look at that more seriously today. |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently it can start with
systemdorsd-execu. I think the difference may be whether the failure happens in the initramfs or the real root. Let's detect both.Here is an example: